error when adding a wellplate after upgrading to PHP8 and Laravel 10

On dev6 machine running version 982c302, when adding a wellplate (from the backend), if we select "yeast" in the multiple checkbox of the 'contenttype' field, we then obtain the following error:

count(): Argument #1 (closed) ($value) must be of type Countable|array, stdClass given

which is indicated to correspond to line 159 of resources / views / vendor / voyager / bread / browse.blade.php

  @if (@count(json_decode($data->{$row->field})) > 0)

Tests:

• Bug does not occur on dev3 running version v2.1.1-beta & PHP7
• On dev6: I can visit again the browse view of wellplates after I delete the problematic entry.
• On dev6: Bug does not occur if I do not check anything in the multiple checkbox of the 'type' field.

added bug essential labels

assigned to @gyvert

changed the description

Todo: On dev6, revert back to Laravel 8 & PHP8 and see if the problem appeared here or later.

assigned to @fduveau and unassigned @gyvert

assigned to @gyvert and unassigned @fduveau

Tests on dev6 (PHP8) reveal that the problem persists after downgrading to 68fa896f (and re-run composer update) which has Laravel 8.

test on dev3 (PHP7) reveal that version 457c13d0 does not have the problem.

So, this issue comes from the migration to PHP8 and not the upgrade to Laravel 9 or 10.

This issue was mentioned (and apparently fixed) in the voyager project.

The fix was to change the line of code by:

@if (@count(json_decode($data->{$row->field}, true)) > 0)

This change is indeed intergrated in the upgrade of Voyager, located in vendor/tcg/voyager/resources/views//bread/browse.blade.php but this view is overriden in MyLabStocks by this one: resources/views/vendor/voyager/bread/browse.blade.php.

We simply need to add the fix in this overriding view.

Done in commit 8feb70e

closed

mentioned in commit 8feb70ec